partially implementing st_equals #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-wm-arthur
approved these changes
Mar 31, 2023
sql/analyzer/indexes.go
Outdated
Comment on lines
41
to
50
| if _, ok := e.(*spatial.Intersects); ok { | ||
| return true | ||
| } | ||
| if _, ok := e.(*spatial.Within); ok { | ||
| return true | ||
| } | ||
| if _, ok := e.(*spatial.STEquals); ok { | ||
| return true | ||
| } | ||
| return false |
There was a problem hiding this comment.
I think using a switch here is more idiomatic for the analyzer:
switch e.(type) {
case *spatial.Intersects, *spatial.Within, *spatial.STEquals:
return true
default:
return false
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL docs for reference: https://dev.mysql.com/doc/refman/8.0/en/spatial-relation-functions-object-shapes.html#function_st-equals
This adds support for
st_equals()only in thePointvsPointcase. There are skipped tests for all other cases.